[ML-47076] Add frequency_quantity in get_validation_horizon to support custom frequency #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wenfeiy-db
approved these changes
Feb 5, 2025
maggiewang-db
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the project, Support custom frequency, see jira ticket for more details.
This PR adds a new input argument,
frequency_quantity, to functionget_validation_horizon. It changes the logic to calculatehorizon_dateoffsetandunit_dateoffsetby multiplying with the givenfrequency_quantity.For testing, I added several test cases under
runtime/tests/automl_runtime/forecast/utils_test.py. Since we only add extra supports of 5 min, 10 min, 15 min and 30 min for now, I only added those test cases.To run the test,